Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3581 - descriptions and hints for all packaging components #3588

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb: new labels
  • edit_new_packagings.dart: systematic description and hint for all packaging components

What

  • Just added labels so that all packaging components have a text field hint and a description.

Screenshot

Screenshots with no values (just text field hints) and expanded descriptions:

top bottom
Capture d’écran 2023-01-17 à 17 47 21 Capture d’écran 2023-01-17 à 17 47 57

Fixes bug(s)

Impacted files:
* `app_en.arb`: new labels
* `edit_new_packagings.dart`: systematic description and hint for all packaging components
@codecov-commenter
Copy link

Codecov Report

Merging #3588 (5ed7eaf) into develop (66cdbf2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3588      +/-   ##
===========================================
- Coverage    11.08%   11.08%   -0.01%     
===========================================
  Files          264      264              
  Lines        13086    13093       +7     
===========================================
  Hits          1451     1451              
- Misses       11635    11642       +7     
Impacted Files Coverage Δ
...oth_app/lib/pages/product/edit_new_packagings.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki added the ✏️ Editing - Packaging input Related to the structured input of food packaging. label Jan 18, 2023
@monsieurtanuki monsieurtanuki merged commit 9c73b0e into openfoodfacts:develop Jan 18, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Packaging input Related to the structured input of food packaging. 🌐 l10n 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example values and explanations on packaging
4 participants