Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3602 - pending background task back to dev mode; better wording #3603

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • background_task_badge.dart: slightly modified the position as we're not using it in the same conditions
  • offline_tasks_page.dart: better wording for "refresh later"
  • page_manager.dart: remove the badge on "profile" icon about background tasks
  • Podfile.lock: wtf
  • user_preferences_dev_mode.dart: put back the access to the pending background task page
  • user_preferences_page.dart: removed the access to the pending background task page

What

  • The "pending background tasks" page is moved (back) from home preferences to dev mode.
  • The "pending background tasks" badge is removed from the bottom profile icon.
  • The wording of "refresh later" tasks has been changed.

Screenshots

new label dev mode
Capture d’écran 2023-01-20 à 13 16 37 Capture d’écran 2023-01-20 à 13 21 21

Fixes bug(s)

Impacted files:
* `background_task_badge.dart`: slightly modified the position as we're not using it in the same conditions
* `offline_tasks_page.dart`: better wording for "refresh later"
* `page_manager.dart`: remove the badge on "profile" icon about background tasks
* `Podfile.lock`: wtf
* `user_preferences_dev_mode.dart`: put back the access to the pending background task page
* `user_preferences_page.dart`: removed the access to the pending background task page
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner January 20, 2023 12:34
@github-actions github-actions bot added background tasks 🍎 iOS iOS specific issues or PRs labels Jan 20, 2023
@monsieurtanuki monsieurtanuki merged commit 4ff4953 into openfoodfacts:develop Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
background tasks 🍎 iOS iOS specific issues or PRs
Projects
None yet
2 participants