Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revamp the signup prompt #3709

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Conversation

Akashsri3bi
Copy link
Contributor

I was little confused about the type of image that would be better , So if there is any changes do tell . I hope it looks fine attaching a screenshot for the same, and didn't change much of text styling wanted to it to be more like as @teolemon showed in picture but thought it would disturb the font and the theme of app .

Screenshot_2023-02-15-23-12-23-97 1

@codecov-commenter
Copy link

Codecov Report

Merging #3709 (41ecd72) into develop (ad46236) will increase coverage by 0.85%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3709      +/-   ##
===========================================
+ Coverage     9.45%   10.30%   +0.85%     
===========================================
  Files          269      272       +3     
  Lines        13571    13754     +183     
===========================================
+ Hits          1283     1418     +135     
- Misses       12288    12336      +48     
Impacted Files Coverage Δ
...pp/lib/pages/product/common/product_refresher.dart 1.75% <0.00%> (-0.21%) ⬇️
packages/smooth_app/lib/main.dart 13.70% <0.00%> (-1.34%) ⬇️
...ib/pages/preferences/user_preferences_connect.dart 5.50% <0.00%> (-1.32%) ⬇️
...ooth_app/lib/background/background_task_badge.dart 8.33% <0.00%> (-0.76%) ⬇️
...es/smooth_app/lib/pages/scan/camera_scan_page.dart 0.43% <0.00%> (-0.01%) ⬇️
...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/edit_new_packagings.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <0.00%> (ø)
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great design wise, I would prefer it a bit smaller, so that it is still visible that it is a alert dialog but I'm open

@Akashsri3bi
Copy link
Contributor Author

Looks great design wise, I would prefer it a bit smaller, so that it is still visible that it is a alert dialog but I'm open

Ha ha It's actually small, I cropped the image so that we can see the design clearly

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, my bad. Looks great @Akashsri3bi

@M123-dev M123-dev merged commit 070b258 into openfoodfacts:develop Feb 18, 2023
@Akashsri3bi Akashsri3bi deleted the ak2 branch February 19, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp the prompt to signup to be more engaging
3 participants