-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revamp the signup prompt #3709
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3709 +/- ##
===========================================
+ Coverage 9.45% 10.30% +0.85%
===========================================
Files 269 272 +3
Lines 13571 13754 +183
===========================================
+ Hits 1283 1418 +135
- Misses 12288 12336 +48
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great design wise, I would prefer it a bit smaller, so that it is still visible that it is a alert dialog but I'm open
Ha ha It's actually small, I cropped the image so that we can see the design clearly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, my bad. Looks great @Akashsri3bi
I was little confused about the type of image that would be better , So if there is any changes do tell . I hope it looks fine attaching a screenshot for the same, and didn't change much of text styling wanted to it to be more like as @teolemon showed in picture but thought it would disturb the font and the theme of app .