fix: 3700 - Fixed widget overflow issues in product editing page #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @Adiii1436!
Please have a look at my comments: I'm sure we'd be better off with Expanded/ flex.
| @@ -228,15 +228,15 @@ class _NutritionPageLoadedState extends State<NutritionPageLoaded> { | |||
| crossAxisAlignment: CrossAxisAlignment.center, | |||
| children: <Widget>[ | |||
| SizedBox( | |||
| width: getColumnSizeFromContext(context, 0.6), | |||
| width: getColumnSizeFromContext(context, 0.55), | |||
There was a problem hiding this comment.
A clean solution would use Expanded and flex:
- we set a fixed width for the unit column (e.g.
getColumnSizeFromContext(context, 0.3) - and we let flutter compute the correct size with
Expandedandflex
There was a problem hiding this comment.
Yes! This is a better solution. Thankyou @monsieurtanuki .
| width: constraints.maxWidth - | ||
| LARGE_SPACE - | ||
| (withClearButton ? MINIMUM_TOUCH_SIZE : 0), | ||
| width: constraints.maxWidth - LARGE_SPACE - MINIMUM_TOUCH_SIZE, |
There was a problem hiding this comment.
Same thing here: use Expanded / flex for the "as big as possible" item, and a fixed size for the trailing widget.
|
I have made changes @monsieurtanuki |
monsieurtanuki
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3700
Before:
After:
It is checked and verified on various screen sizes.