Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure we use the three dots character and not three characters #3812

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix: Ensure we use the three dots character and not three characters #3812

merged 1 commit into from
Mar 27, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Mar 25, 2023

Small fix to use the three dots character … and not three dots ...

  • a small syntax fix: we shouldn't use a comma before three dots

@g123k g123k self-assigned this Mar 25, 2023
@g123k g123k requested a review from a team as a code owner March 25, 2023 09:41
@g123k g123k changed the title Translations, ensure we use the three dots character and not three characters Ensure we use the three dots character and not three characters Mar 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3812 (58fed0e) into develop (9d2db67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3812   +/-   ##
========================================
  Coverage    10.67%   10.67%           
========================================
  Files          272      272           
  Lines        13547    13547           
========================================
  Hits          1446     1446           
  Misses       12101    12101

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k g123k changed the title Ensure we use the three dots character and not three characters [fix] Ensure we use the three dots character and not three characters Mar 25, 2023
@g123k g123k changed the title [fix] Ensure we use the three dots character and not three characters fix: Ensure we use the three dots character and not three characters Mar 25, 2023
M123-dev
M123-dev approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know there was a three dots character 👍🏼

Also nice to see you again @g123k

@M123-dev M123-dev merged commit 0d48729 into openfoodfacts:develop Mar 27, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
@g123k g123k deleted the three_dots_translations branch December 30, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

@M123-dev M123-dev M123-dev approved these changes

Assignees

@g123k g123k

Labels
🌐 l10n translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g123k @codecov-commenter @teolemon @M123-dev