fix: visual inconsistency in app_settings #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: bottom padding for rate us tile - fix: misalignment of share icon refactor: added user_preferences list tile - which is used for both rate us and share app tile
language pickers are different - added the same border radius to language picker
Codecov Report
@@ Coverage Diff @@
## develop #3818 +/- ##
===========================================
- Coverage 10.67% 10.66% -0.01%
===========================================
Files 272 272
Lines 13547 13554 +7
===========================================
Hits 1446 1446
- Misses 12101 12108 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
reviewed
Mar 27, 2023
packages/smooth_app/lib/generic_lib/widgets/language_selector.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/preferences/user_preferences_widgets.dart
Outdated
Show resolved
Hide resolved
|
@g123k added the changes! Thanks |
g123k
reviewed
Mar 31, 2023
| @@ -132,6 +125,24 @@ class LanguageSelectorSettings extends StatelessWidget { | |||
| }, | |||
| ); | |||
| }, | |||
| borderRadius: ANGULAR_BORDER_RADIUS, | |||
| child: Container( | |||
There was a problem hiding this comment.
You can remove the Container here, it's totally useless
There was a problem hiding this comment.
Yesss I will make the suggested changes!
- remove unnecessary container in language_selector - inAppsettings tile made the icon leading instead of trailing
|
@g123k I have made the chnges ! sorry for the delay ! |
g123k
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot
Fixes bug(s)
Part of