Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3780 - testing ios compilation with mobile_scanner fix #3822

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • pubspec.yaml: temporarily using the master branch for mobile_scanner

What

  • There were compilation problems in ios, probably due to different xcode versions, inside package mobile_scanner.
  • Some code was merged (fix: 544 - explicit returned type for compactMap juliansteenbakker/mobile_scanner#568) that is supposed to fix it.
  • The current PR is a test if the compilation problems would go away with the latest mobile_scanner code.
  • Eventually, there would be a new release of mobile_scanner and we would use it directly.

Fixes bug(s)

Impacted file:
* `pubspec.yaml`: temporarily using the master branch for mobile_scanner
@codecov-commenter
Copy link

Codecov Report

Merging #3822 (6949343) into develop (0d48729) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3822   +/-   ##
========================================
  Coverage    10.67%   10.67%           
========================================
  Files          272      272           
  Lines        13547    13546    -1     
========================================
  Hits          1446     1446           
+ Misses       12101    12100    -1     
Impacted Files Coverage Δ
...mooth_app/lib/pages/product/edit_product_page.dart 0.45% <0.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@monsieurtanuki monsieurtanuki merged commit b1df237 into openfoodfacts:develop Mar 29, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for the review!
@juliansteenbakker I'm not 100% sure everything has been tested yet (like, the full build of our app on ios with your master branch), but we'll keep you posted rapidly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS build is failing due to mobile_scanner
3 participants