Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvement for language & country selectors #3835

Closed
g123k opened this issue Mar 31, 2023 · 5 comments · Fixed by #3936
Closed

Usability improvement for language & country selectors #3835

g123k opened this issue Mar 31, 2023 · 5 comments · Fixed by #3936
Assignees

Comments

@g123k
Copy link
Collaborator

g123k commented Mar 31, 2023

Hi everyone,

As I was checking the PR fixing visual inconsistencies in the app settings, I think we should improve selectors for both the language and the country.

Currently, when opening the dialog, the list is always at the top, and we need to scroll to know which country/language is selected.

To improve the UX, we should:

  • Scroll to the position where we can see the selected item
  • Or move the selected item to the first position

I don't have any strong advice on the solution, but that's a kind of small UX issue, that we can fix easily.

Video

A video of the current issue:

RocketSim_Recording_iPhone_14_Pro_2023-03-31_10.39.36.mp4
@M123-dev
Copy link
Member

M123-dev commented Apr 1, 2023

I'd prefer scrolling the the currently selected lc/cc, breaking order could get confusing

@monsieurtanuki
Copy link
Contributor

For the record with the multilingual image feature I had to add to the language selector "pre-selected languages".
For instance, an image is available in French and Spanish: the language selector displays French as checked, Spanish as checked, and then all the languages in alphabetical order.

@monsieurtanuki
Copy link
Contributor

@g123k Is that OK with you if I finish this one? Again, as a side-effect of multilingual images (where we can have several languages selected) I implemented something for languages; I could code the same thing for country.
Screenshot_2023-04-28-19-52-36

@g123k
Copy link
Collaborator Author

g123k commented May 1, 2023

Yes, feel free to do so. Having the selected languages at the top seems to be the better way to implement the feature

@monsieurtanuki
Copy link
Contributor

Fixed by #3936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants