chore: upgraded to off-dart 2.5.0 #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `congrats.dart`: refactored Robotoff call * `product_question_page.dart`: refactored Robotoff call * `product_questions_query.dart`: refactored Robotoff call * `pubspec.lock`: wtf * `pubspec.yaml`: now using the latest 2.5.0 off-dart version; downgraded path accordingly * `question_page.dart`: refactored Robotoff call * `questions_query.dart`: refactored Robotoff call * `simple_input_text_field.dart`: now using the new `SuggestionManager` class
Codecov Report
@@ Coverage Diff @@
## develop #3876 +/- ##
===========================================
- Coverage 10.52% 10.48% -0.05%
===========================================
Files 273 274 +1
Lines 13468 13526 +58
===========================================
Hits 1418 1418
- Misses 12050 12108 +58
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
requested changes
Apr 18, 2023
packages/smooth_app/lib/pages/product/simple_input_text_field.dart
Outdated
Show resolved
Hide resolved
Impacted file: * `simple_input_text_field.dart`: after review
g123k
approved these changes
Apr 21, 2023
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
congrats.dart: refactored Robotoff callproduct_question_page.dart: refactored Robotoff callproduct_questions_query.dart: refactored Robotoff callpubspec.lock: wtfpubspec.yaml: now using the latest 2.5.0 off-dart version; downgraded path accordinglyquestion_page.dart: refactored Robotoff callquestions_query.dart: refactored Robotoff callsimple_input_text_field.dart: now using the newSuggestionManagerclassWhat