Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Try/catch the exception that may be raised when changing the flash state #3878

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: Try/catch the exception that may be raised when changing the flash state #3878

merged 1 commit into from
Apr 17, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Apr 17, 2023

Hi everyone!

As suggested by @CoryADavis in #3873, we should try/catch the exception that can be raised by the platform when when changing the state of the flash.

Usually, this comes from the torch mode activated in parallel on the phone.

@g123k g123k requested a review from a team as a code owner April 17, 2023 11:28
@github-actions github-actions bot added 🌐 l10n 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Apr 17, 2023
M123-dev
M123-dev approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @g123k, I'm going to quick-merge as I am working on the F-Droid modularization, hopefully I can avoid merge conflicts :D

@M123-dev M123-dev merged commit 92e361e into openfoodfacts:develop Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Merged
@g123k g123k deleted the handle_flash_error branch December 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@g123k g123k

Labels
🌐 l10n 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g123k @M123-dev