-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 3863 - multilingual input for product name #3890
feat: 3863 - multilingual input for product name #3890
Conversation
Impacted files: * `language_selector.dart`: moved code to new static method `openLanguageSelector` * `user_preferences_languages_list.dart`: minor refactoring * `user_preferences_settings.dart`: minor refactoring
Codecov Report
@@ Coverage Diff @@
## develop #3890 +/- ##
===========================================
- Coverage 10.59% 10.55% -0.04%
===========================================
Files 270 270
Lines 13366 13424 +58
===========================================
+ Hits 1416 1417 +1
- Misses 11950 12007 +57
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted files: * `language_selector.dart`: added the concept of "pre selected languages" and their different displays * `product_query.dart`: added a `TODO` * `user_preferences_settings.dart`: minor refactoring
Impacted files: * `add_basic_details_page.dart`: introduced the multilingual input * `language_selector.dart`: added an optional "displayed language" parameter, useful for `AddBasicDetailsPage` * `product_query.dart`: now we download the `NAME_ALL_LANGUAGES` product field too * `up_to_date_changes.dart`: now we manage the `productNameInLanguages` product field too
Impacted file: * `add_basic_details_page.dart`
@teolemon The UX is very smooth for multilingual product names. Now is
There's still a bit confusion on "how to get rid of a translation": sometimes if you put an empty String it removes the translation for that language, sometimes it sets it to ...erm... an empty String. Some multilingual products to play with:
|
Thank you @teolemon for your approval! |
@monsieurtanuki testing in the internal, I realize that products with one language don't have the option to add more languages |
@teolemon What you mean is that "old" products don't have the option to add more languages. |
Impacted files:
language_selector.dart
: moved code to new static methodopenLanguageSelector
user_preferences_languages_list.dart
: minor refactoringuser_preferences_settings.dart
: minor refactoringWhat
Part of