feat: 3880 - added a "get photo" button on the edit packaging component page #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt page Impacted files: * `edit_new_packagings.dart`: added a "get photo" button on top; refactored with the up-to-date provider * `image_field_extension.dart`: new `getPhotoButton` method * `nutrition_page_loaded.dart`: refactored with the up-to-date provider and the new `getPhotoButton` method
github-actions
bot
added
✏️ Editing - Nutrition input
✏️ Editing - Packaging input
Codecov Report
@@ Coverage Diff @@
## develop #3942 +/- ##
===========================================
- Coverage 11.01% 11.00% -0.01%
===========================================
Files 264 264
Lines 13033 13044 +11
===========================================
Hits 1435 1435
- Misses 11598 11609 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
May 13, 2023
There was a problem hiding this comment.
Thanks a lot @monsieurtanuki :D
The pages are starting to get full with those large buttons. Maybe we have to switch to smaller ones eventually of we add more 😄
|
Thank you @M123-dev for your reviews! Anyway this page is doomed to be crowded, with the user inserting new packaging components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
edit_new_packagings.dart: added a "get photo" button on top; refactored with the up-to-date providerimage_field_extension.dart: newgetPhotoButtonmethodnutrition_page_loaded.dart: refactored with the up-to-date provider and the newgetPhotoButtonmethod