Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fastlane for English, before we can find a more i18n solution for F-Droid #3960

Merged
merged 3 commits into from
May 18, 2023

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented May 11, 2023

What

  • fix: add fastlane for English, before we can find a more i18n solution for F-Droid
  • Will be a partial fix for Set up fastlane for metadata #3950
  • The visuals and the icon are old. I need to fetch new ones from Figma of from the PlayStore listing

What we should really be doing

Context

@teolemon teolemon added fastlane Automation of releases and marketing assets deployment F-Droid labels May 11, 2023
@teolemon teolemon requested a review from a team as a code owner May 11, 2023 13:01
@github-actions github-actions bot removed the fastlane Automation of releases and marketing assets deployment label May 11, 2023
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how fastlane works, but meanwhile I approve.

Btw: nice app screenshots where the scanner is in the middle of the screen and the product card takes only a small space in the bottom.

@monsieurtanuki
Copy link
Contributor

@teolemon As long as #3956 is not approved and merged, all PRs will fail.

@teolemon teolemon requested a review from M123-dev May 15, 2023 11:57
@codecov-commenter
Copy link

Codecov Report

Merging #3960 (1b6943c) into develop (2701975) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3960      +/-   ##
===========================================
- Coverage    11.01%   10.99%   -0.02%     
===========================================
  Files          264      265       +1     
  Lines        13033    13046      +13     
===========================================
  Hits          1435     1435              
- Misses       11598    11611      +13     

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member Author

@teolemon teolemon merged commit b59d19f into develop May 18, 2023
@teolemon teolemon deleted the fastlane-desc branch May 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants