Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3987 - now KP opens the new packaging page #3989

Merged
merged 1 commit into from
May 20, 2023

Conversation

monsieurtanuki
Copy link
Contributor

New file:

  • add_packaging_button.dart: "Add (new) packaging" button for user contribution.

Impacted file:

  • knowledge_panel_action_card.dart: now opens the new packaging page; refactoring

What

  • Now the knowledge panel action opens the new packaging page instead of the Packaging OCR page

Fixes bug(s)

New file:
* `add_packaging_button.dart`: "Add (new) packaging" button for user contribution.

Impacted file:
* `knowledge_panel_action_card.dart`: now opens the new packaging page; refactoring
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the standard knowledge panel actions here, or extending the custom buttons made for ingredients and nutrition ?

@monsieurtanuki
Copy link
Contributor Author

@teolemon I'm not sure what you mean, as in all cases for KP actions we somehow use addPanelButton, including for ingredients and nutrition (which don't have different buttons at all).
Therefore, I confirm that the new "add (new) packaging" button looks like all the other KP action buttons.

@teolemon
Copy link
Member

Ok, good, sorry for the confusion

@teolemon teolemon merged commit 72c55f6 into openfoodfacts:develop May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap the knowledge panel action to the new packaging edition system
2 participants