Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: On the product page, the Ripple on the back button doesn't work #3998

Merged
merged 1 commit into from
May 26, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 23, 2023

Hi everyone,

One more fix for an invisible ripple:
untitled.webm

@g123k g123k self-assigned this May 23, 2023
@g123k g123k requested a review from a team as a code owner May 23, 2023 08:10
@codecov-commenter
Copy link

Codecov Report

Merging #3998 (242b137) into develop (76762b1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3998      +/-   ##
===========================================
- Coverage    10.96%   10.95%   -0.01%     
===========================================
  Files          265      266       +1     
  Lines        13090    13106      +16     
===========================================
+ Hits          1435     1436       +1     
- Misses       11655    11670      +15     
Impacted Files Coverage Δ
...pp/lib/generic_lib/widgets/smooth_back_button.dart 93.75% <100.00%> (+0.41%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ripple effect, by @g123k

@teolemon teolemon merged commit 950c18b into openfoodfacts:develop May 26, 2023
@g123k g123k deleted the ripple_back_button branch May 26, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants