Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4031 - different layout for "empty" product list page #4052

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb: removed the ! from the "start scanning" label
  • app_fr.arb: removed the ! from the "start scanning" label
  • product_list_page.dart: FAB instead of custom button; different layout for svg and text

What

  • Different layout for "empty" product list page
    • FAB instead of custom button
    • Different layout for svg and text

Screenshot

Screenshot_2023-05-30-10-03-38

Fixes bug(s)

Impacted files:
* `app_en.arb`: removed the `!` from the "start scanning" label
* `app_fr.arb`: removed the `!` from the "start scanning" label
* `product_list_page.dart`: FAB instead of custom button; different layout for svg and text
@codecov-commenter
Copy link

Codecov Report

Merging #4052 (304ab7a) into develop (a007367) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4052   +/-   ##
========================================
  Coverage    11.00%   11.00%           
========================================
  Files          270      270           
  Lines        13369    13364    -5     
========================================
  Hits          1471     1471           
+ Misses       11898    11893    -5     
Impacted Files Coverage Δ
...pp/lib/pages/product/common/product_list_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better :-)

@teolemon teolemon merged commit e48599d into openfoodfacts:develop Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamping the History empty screen
3 participants