Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual touch up for the product addition #4058

Closed
12 tasks done
teolemon opened this issue Jun 1, 2023 · 2 comments · Fixed by #4071
Closed
12 tasks done

Visual touch up for the product addition #4058

teolemon opened this issue Jun 1, 2023 · 2 comments · Fixed by #4071
Assignees
@monsieurtanuki
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Jun 1, 2023 •
edited by monsieurtanuki
Loading

image

Here's what the mockups would require to implement

  • Replace the Tick by 1 and 2 (requires icon change c)
  • Add Header “Compute the Eco-Score” “Compute the Nutri-Score”
  • Add subheader “Help us by filling at least a category and nutritional values” “Help us by filling at least a category”
  • Add crayon edit icon to clarify editability at all times
  • Color the fields based on local product status
  • Make the nutrition facts unselectable until a category has been provided
  • Create a new edit screen concatenating facultative eco-score fields
  • Link the facultative eco-score fields edit screen to the new product addition “Make Eco-Score computation more precise with origins, packaging & more”
    • Origins field (for origins)
    • Ingredients field (for palm oil, origins mostly)
    • Labels (for Environmental labels)
    • Packaging

Originally posted by @teolemon in #4054 (comment)
@teolemon teolemon added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label Jun 1, 2023
@monsieurtanuki monsieurtanuki self-assigned this Jun 2, 2023
This was referenced Jun 2, 2023
Merged
Closed
@monsieurtanuki
Copy link
Contributor

@teolemon I would prefer an expand/collapse button for the facultative ecoscore edits, instead of a new page. Less friction. Is that OK with you?

@teolemon
Copy link
Member Author

teolemon commented Jun 3, 2023

Yes, let's try this way

@monsieurtanuki monsieurtanuki mentioned this issue Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 4058 - expand/collapse for additional ecoscore fields monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki