Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to remove a product not found from the carousel #4126

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 12, 2023

Hi everyone,

This PR allows showing the close button on all cards.
This button is now a dedicated Widget to prevent duplicated code.

Screenshot_1686553803

Will fix #4125

@g123k g123k requested a review from a team as a code owner June 12, 2023 07:12
@g123k g123k self-assigned this Jun 12, 2023
@teolemon
Copy link
Member

Can you instrument it so that we can get a signal of how many people don't care about contribution

@g123k
Copy link
Collaborator Author

g123k commented Jun 12, 2023

Can you instrument it so that we can get a signal of how many people don't care about contribution

Is-it OK with:

tag: 'ignore product',
category: AnalyticsCategory.couldNotFindProduct,

(The category is already used)

@codecov-commenter
Copy link

Codecov Report

Merging #4126 (d5bbb8d) into develop (abab934) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4126      +/-   ##
===========================================
- Coverage    10.88%   10.87%   -0.01%     
===========================================
  Files          273      273              
  Lines        13568    13578      +10     
===========================================
  Hits          1477     1477              
- Misses       12091    12101      +10     
Impacted Files Coverage Δ
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)
.../cards/product_cards/smooth_product_base_card.dart 0.00% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
...mooth_app/lib/widgets/smooth_product_carousel.dart 2.45% <0.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the 📈 Analytics We use Sentry and Matomo, with an opt-in system label Jun 12, 2023
@teolemon teolemon merged commit 74c00ae into openfoodfacts:develop Jun 12, 2023
@g123k g123k deleted the remove_product_not_found branch December 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system product scan carousel scan card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can't remove a "Product not found" card
3 participants