fix: 4123 - dedicated widget and page for robotoff question images #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `question_image_full_page.dart`: Zoomable full page of a question image. * `question_image_thumbnail.dart`: Thumbnail of a question image. Impacted files: * `product_image_carousel.dart`: removed a now unreachable case. * `question_card.dart`: now displays the question image with a new zoomable read-only widget
Codecov Report
@@ Coverage Diff @@
## develop #4135 +/- ##
===========================================
- Coverage 10.88% 10.86% -0.03%
===========================================
Files 273 275 +2
Lines 13568 13599 +31
===========================================
Hits 1477 1477
- Misses 12091 12122 +31
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @teolemon for your review and for your lecture at Collège de France! |
|
I'm a bit too late on this, but the back button on the bottom right is an antipattern, it should also be at the top/left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Part of
Files
New files:
question_image_full_page.dart: Zoomable full page of a question image.question_image_thumbnail.dart: Thumbnail of a question image.Impacted files:
product_image_carousel.dart: removed a now unreachable case.question_card.dart: now displays the question image with a new zoomable read-only widget