Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4164 - added a nova section for add new product page #4167

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a Nova section in the "add new product" page

Screenshot

new nova section category input
Screenshot_2023-06-15-17-28-49 Screenshot_2023-06-15-17-29-13
ingredients input well done!
Screenshot_2023-06-15-17-29-52 Screenshot_2023-06-15-17-30-06

Fixes bug(s)

Impacted files

  • add_new_product_page.dart: added a paragraph for nova
  • app_en.arb: added a title and a subtitle for nova
  • app_fr.arb: added a title and a subtitle for nova
  • product_dialog_helper.dart: added an unknow logo for nova

Impacted files:
* `add_new_product_page.dart`: added a paragraph for nova
* `app_en.arb`: added a title and a subtitle for nova
* `app_fr.arb`: added a title and a subtitle for nova
* `product_dialog_helper.dart`: added an unknow logo for nova
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 15, 2023 15:39
@monsieurtanuki monsieurtanuki requested a review from teolemon June 15, 2023 15:39
@github-actions github-actions bot added 🌐 l10n Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Jun 15, 2023
monsieurtanuki and others added 2 commits June 15, 2023 18:35
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
@teolemon
Copy link
Member

@monsieurtanuki White on White buttons
image

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki White on White buttons

Already mentioned in #3974.

@teolemon teolemon mentioned this pull request Jun 15, 2023
@teolemon teolemon added the NOVA groups NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova label Jun 15, 2023
@teolemon teolemon requested a review from g123k June 15, 2023 19:04
@teolemon
Copy link
Member

@monsieurtanuki is there a way to add the explicitation of the food processing level next to NOVA ?
As simple as adding the group name "Processed foods". User feedback is that they don't understand it without explanation, and it will be for many their first exposure to it.

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki is there a way to add the explicitation of the food processing level next to NOVA ?

Sure! Just send me a lousy mock-up and I'll add the text where you want.

@teolemon
Copy link
Member

Something as simplistic as that:
image

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

Impacted files:
* `add_new_product_page.dart`: added a label to the nova logo
* `app_en.arb`: added "category" to the nova subtitle; added a label for the nova logo when unknown
* `app_fr.arb`: added "category" to the nova subtitle; added a label for the nova logo when unknown
@monsieurtanuki
Copy link
Contributor Author

empty product nova half-unknown nova computed
Screenshot_2023-06-16-15-30-18 Screenshot_2023-06-16-15-30-38 Screenshot_2023-06-16-15-31-14

@monsieurtanuki monsieurtanuki merged commit c4c2929 into openfoodfacts:develop Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 l10n NOVA groups NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a product addition section on Food Ultra-Processing
2 participants