refactor: reorder menuitems on history page #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohd Jasir Noor Khan <khanmohdjasir@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #4181 +/- ##
========================================
Coverage 10.87% 10.87%
========================================
Files 276 276
Lines 13591 13591
========================================
Hits 1478 1478
Misses 12113 12113
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @khanjasir90, Thanks for your PR. |
|
@g123k how about doing it in another PR. So that this PR context is more relevant to the mentioned issue? |
g123k
reviewed
Jun 16, 2023
| @@ -1306,7 +1306,7 @@ | |||
| "@added_to_list_msg": { | |||
| "description": "Message when products have been successfully added to a list" | |||
| }, | |||
| "user_list_popup_clear": "Clear", | |||
| "user_list_popup_clear": "Clear your history", | |||
| "@user_list_popup_clear": { | |||
| "description": "Short label of a 'clear list' popup" | |||
There was a problem hiding this comment.
Could you change the description of this translation? As Clear list is incorrect.
Signed-off-by: Mohd Jasir Noor Khan <khanmohdjasir@gmail.com>
g123k
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reorder menu items of History Page from
Clear, View on the web, SharetoShare, View on Web, Clear you historyScreenshot