Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to animate lists (in the product edition flow) #4195

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 17, 2023

Hi everyone,

As part of #3986, I want to be able to animate the insertion/removal of an item.
This PR simply adds this feature, that you can see in action: AnimatedLists.webm

Edit: I've also improved a bit the accessibility with the + button
Screenshot_1687010455

@g123k g123k added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Jun 17, 2023
@g123k g123k requested a review from a team as a code owner June 17, 2023 13:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Merging #4195 (c26a89c) into develop (38b2b8a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4195      +/-   ##
===========================================
- Coverage    10.88%   10.86%   -0.03%     
===========================================
  Files          277      277              
  Lines        13600    13629      +29     
===========================================
  Hits          1481     1481              
- Misses       12119    12148      +29     
Impacted Files Coverage Δ
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch

@M123-dev M123-dev merged commit d518c85 into openfoodfacts:develop Jun 18, 2023
@g123k g123k deleted the animated_lists branch June 18, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animations ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants