Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to change the portion size #4203

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 18, 2023

Hi everyone,

Here is a fix for the portion size, where we reset the value in the controller for nothing.
But the real issue is still #4199

@g123k g123k requested a review from a team as a code owner June 18, 2023 10:50
@g123k g123k linked an issue Jun 18, 2023 that may be closed by this pull request
@g123k g123k changed the title Fix: unable to change the portion size fix: unable to change the portion size Jun 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4203 (5087748) into develop (38b2b8a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4203      +/-   ##
===========================================
- Coverage    10.88%   10.88%   -0.01%     
===========================================
  Files          277      277              
  Lines        13600    13601       +1     
===========================================
  Hits          1481     1481              
- Misses       12119    12120       +1     
Impacted Files Coverage Δ
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@M123-dev M123-dev merged commit e87143e into openfoodfacts:develop Jun 18, 2023
@g123k g123k deleted the nutrition_fact_portion_size branch June 18, 2023 16:34
@teolemon
Copy link
Member

teolemon commented Jun 18, 2023

Was is related to the toggle being on 100 g ?
I can't reproduce in either per portion nor 100g
In short, was it a behaviour introduced on purpose ? We have this behaviour where we wipe the portion size on toggling
@g123k @M123-dev

@g123k
Copy link
Collaborator Author

g123k commented Jun 18, 2023

The problem was actually because of the performance issue forcing the textfield to always reset itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can't change the portion size
4 participants