-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 4231 - "new product" scan card with display flexibility #4232
fix: 4231 - "new product" scan card with display flexibility #4232
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4232 +/- ##
===========================================
- Coverage 11.00% 10.94% -0.07%
===========================================
Files 282 282
Lines 14015 14092 +77
===========================================
- Hits 1543 1542 -1
- Misses 12472 12550 +78
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can we circle the close cross ? |
Impacted files: * `smooth_product_base_card.dart`: added an optional `iconData` parameter * `smooth_product_card_not_found.dart`: specific "circled cross" icon parameter
Done. |
Would you have a screenshot of how it looks @monsieurtanuki ? |
Not for the moment: I just quickly changed the code and used a different icon: "My" icon does not have the "strong X and light circle" effect mentioned in your link, and I don't know how relevant it is to you.
Which goes beyond the purpose of the PR - and I have a limited access to my computer. |
Ok, let's try as is. |
Thank you @teolemon for your review! Don't hesitate to create an issue regarding the consistency of "X" icons if relevant. |
What
AutoSizeText
andExpanded
Screenshot
Fixes bug(s)