Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-enable analytics on FDroid builds #4289

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 10, 2023

Hi everyone!

On F-Droid builds, the user consent is asked, but we never sent data when we have the consent.
This PR disables the temporary behavior we had implemented.

@g123k g123k self-assigned this Jul 10, 2023
@g123k g123k requested a review from a team as a code owner July 10, 2023 12:48
@github-actions github-actions bot added the 📈 Analytics We use Sentry and Matomo, with an opt-in system label Jul 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4289 (432aeca) into develop (505c0d1) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4289   +/-   ##
========================================
  Coverage    10.87%   10.87%           
========================================
  Files          285      285           
  Lines        14172    14170    -2     
========================================
  Hits          1541     1541           
+ Misses       12631    12629    -2     
Impacted Files Coverage Δ
...kages/smooth_app/lib/helpers/analytics_helper.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k g123k merged commit 7dd3983 into openfoodfacts:develop Jul 13, 2023
@g123k g123k deleted the re_enable_fdroid branch July 13, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system F-Droid 📈 Matomo Sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants