Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improvement for the dialog to create a new list, when there is none #4296

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 13, 2023

Hi everyone!

As noted in #4293, the current dialog shown when there is no user list has some UI issues.
Here is the new look:

Screenshot_1689227678

…ne was not optimized (horizontal button, weird spacings…)
@g123k g123k self-assigned this Jul 13, 2023
@g123k g123k requested a review from a team as a code owner July 13, 2023 05:58
@g123k g123k linked an issue Jul 13, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4296 (5ff7f31) into develop (cac58a2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4296      +/-   ##
===========================================
- Coverage    10.79%   10.79%   -0.01%     
===========================================
  Files          287      287              
  Lines        14288    14290       +2     
===========================================
  Hits          1542     1542              
- Misses       12746    12748       +2     
Impacted Files Coverage Δ
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 88.18% <ø> (ø)
...app/lib/pages/product_list_user_dialog_helper.dart 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@g123k
Copy link
Collaborator Author

g123k commented Jul 13, 2023

Thanks for your review @monsieurtanuki

@g123k g123k merged commit 79aad85 into openfoodfacts:develop Jul 13, 2023
@g123k g123k deleted the no_userlist_dialog branch July 13, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiny button to create a new list
3 participants