Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Camera Visor: force icons to always be white #4340

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 19, 2023

Hi everyone,

In some cases, the icons in the visor may be black.
Here is a simple fix to ensure it's always white.

Screenshot_1689772474

@g123k g123k added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jul 19, 2023
@g123k g123k self-assigned this Jul 19, 2023
@g123k g123k requested a review from a team as a code owner July 19, 2023 13:16
@github-actions github-actions bot removed the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jul 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4340 (d950844) into develop (5b376d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4340   +/-   ##
========================================
  Coverage    10.54%   10.54%           
========================================
  Files          290      290           
  Lines        14294    14294           
========================================
  Hits          1507     1507           
  Misses       12787    12787           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you even managed to get it black 😆

@M123-dev M123-dev merged commit 46b6faa into openfoodfacts:develop Jul 20, 2023
@g123k g123k deleted the vison_icon_color branch December 30, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants