chore: capitalize method for String #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `string_extension.dart`: extension for `String` Impacted file: * `user_preferences_languages_list.dart`: now using the new `String` extension instead of deprecated library
g123k
reviewed
Oct 27, 2023
| extension StringExtension on String { | ||
| String capitalize() => isEmpty | ||
| ? this | ||
| : this[0].toUpperCase() + (length == 1 ? '' : substring(1)); |
There was a problem hiding this comment.
You can simplify, but replacing (length == 1 ? '' : substring(1) with just substring(1)
There was a problem hiding this comment.
@g123k I'll try that, but I would be surprised if substring accepted a starting index beyond the string.
There was a problem hiding this comment.
@g123k Fair enough, it does work! I still don't see the logic behind it though...
Codecov Report
@@ Coverage Diff @@
## develop #4734 +/- ##
==========================================
- Coverage 9.90% 9.90% -0.01%
==========================================
Files 310 312 +2
Lines 15807 15808 +1
==========================================
- Hits 1566 1565 -1
- Misses 14241 14243 +2
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
g123k
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
capitalizemethod forStringfrom an outdated package, and that prevents us from upgrading packageflutter_native_splash.Stringextension.flutter_native_splash.Part of
Files
New file:
string_extension.dart: extension forStringImpacted file:
user_preferences_languages_list.dart: now using the newStringextension instead of deprecated library