Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgraded flutter_map to 6.0.1 #4757

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Upgraded flutter_map to 6.0.1
  • Domino effect regarding other packages needing to be upgraded too.

Part of

Impacted files

  • add_new_product_page.dart: matomo upgrade
  • analytics_helper.dart: matomo upgrade
  • camera_scan_page.dart: matomo upgrade
  • forgot_password_page.dart: matomo upgrade
  • knowledge_panel_page.dart: matomo upgrade
  • knowledge_panel_world_map_card.dart: flutter_map upgrade
  • login_page.dart: matomo upgrade
  • main.dart: matomo upgrade
  • new_product_page.dart: matomo upgrade
  • personalized_ranking_page.dart: matomo upgrade
  • product_list_page.dart: matomo upgrade
  • product_query_page.dart: matomo upgrade
  • pubspec.lock: wtf
  • pubspec.yaml: upgraded flutter_map to 6.0.1 (+ domino effect)
  • question_page.dart: matomo upgrade
  • sign_up_page.dart: matomo upgrade
  • user_preferences_page.dart: matomo upgrade

Impacted files:
* `add_new_product_page.dart`: matomo upgrade
* `analytics_helper.dart`: matomo upgrade
* `camera_scan_page.dart`: matomo upgrade
* `forgot_password_page.dart`: matomo upgrade
* `knowledge_panel_page.dart`: matomo upgrade
* `knowledge_panel_world_map_card.dart`: flutter_map upgrade
* `login_page.dart`: matomo upgrade
* `main.dart`: matomo upgrade
* `new_product_page.dart`: matomo upgrade
* `personalized_ranking_page.dart`: matomo upgrade
* `product_list_page.dart`: matomo upgrade
* `product_query_page.dart`: matomo upgrade
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded flutter_map to 6.0.1 (+ domino effect)
* `question_page.dart`: matomo upgrade
* `sign_up_page.dart`: matomo upgrade
* `user_preferences_page.dart`: matomo upgrade
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner November 1, 2023 08:36
@github-actions github-actions bot added 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 📈 Analytics We use Sentry and Matomo, with an opt-in system 👥 User management Account login, signup, signout dependencies 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… User lists labels Nov 1, 2023
Impacted file:
* `mocks.dart`: matomo upgrade
@github-actions github-actions bot added the MacOS label Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (c85f0bd) 9.92% compared to head (1a06662) 9.90%.

Files Patch % Lines
...kages/smooth_app/lib/helpers/analytics_helper.dart 0.00% 13 Missing ⚠️
...owledge_panels/knowledge_panel_world_map_card.dart 0.00% 4 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 3 Missing ⚠️
...es/smooth_app/lib/pages/scan/camera_scan_page.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4757      +/-   ##
==========================================
- Coverage     9.92%   9.90%   -0.02%     
==========================================
  Files          310     310              
  Lines        15766   15756      -10     
==========================================
- Hits          1565    1561       -4     
+ Misses       14201   14195       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k
Copy link
Collaborator

g123k commented Nov 13, 2023

The previous migration for Matamo was a disaster, as there were no event sent.
Have you checked they are still sent?

@monsieurtanuki
Copy link
Contributor Author

The previous migration for Matamo was a disaster, as there were no event sent. Have you checked they are still sent?

No I haven't, and I wouldn't even know how to do it.
The thing is that the flutter_map upgrade needs a new version of http, which impacts other packages, including matomo. So, either matomo behaves this time, or we're stuck forever with old versions for many packages. While still receiving bump emails.

@g123k
Copy link
Collaborator

g123k commented Nov 17, 2023

Ok, let me run your PR.
I will check that for you.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking if the request is sent the answer is YES + with correct data (the previous issue was that all users were anonymized)

@monsieurtanuki monsieurtanuki merged commit 0ddd5c6 into openfoodfacts:develop Nov 17, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you very much @g123k for your review and your tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system dependencies MacOS Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🧪 Tests User lists 👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants