-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgraded flutter_map to 6.0.1 #4757
chore: upgraded flutter_map to 6.0.1 #4757
Conversation
Impacted files: * `add_new_product_page.dart`: matomo upgrade * `analytics_helper.dart`: matomo upgrade * `camera_scan_page.dart`: matomo upgrade * `forgot_password_page.dart`: matomo upgrade * `knowledge_panel_page.dart`: matomo upgrade * `knowledge_panel_world_map_card.dart`: flutter_map upgrade * `login_page.dart`: matomo upgrade * `main.dart`: matomo upgrade * `new_product_page.dart`: matomo upgrade * `personalized_ranking_page.dart`: matomo upgrade * `product_list_page.dart`: matomo upgrade * `product_query_page.dart`: matomo upgrade * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded flutter_map to 6.0.1 (+ domino effect) * `question_page.dart`: matomo upgrade * `sign_up_page.dart`: matomo upgrade * `user_preferences_page.dart`: matomo upgrade
Impacted file: * `mocks.dart`: matomo upgrade
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4757 +/- ##
==========================================
- Coverage 9.92% 9.90% -0.02%
==========================================
Files 310 310
Lines 15766 15756 -10
==========================================
- Hits 1565 1561 -4
+ Misses 14201 14195 -6 ☔ View full report in Codecov by Sentry. |
The previous migration for Matamo was a disaster, as there were no event sent. |
No I haven't, and I wouldn't even know how to do it. |
Ok, let me run your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking if the request is sent the answer is YES + with correct data (the previous issue was that all users were anonymized)
Thank you very much @g123k for your review and your tests! |
What
Part of
Impacted files
add_new_product_page.dart
: matomo upgradeanalytics_helper.dart
: matomo upgradecamera_scan_page.dart
: matomo upgradeforgot_password_page.dart
: matomo upgradeknowledge_panel_page.dart
: matomo upgradeknowledge_panel_world_map_card.dart
: flutter_map upgradelogin_page.dart
: matomo upgrademain.dart
: matomo upgradenew_product_page.dart
: matomo upgradepersonalized_ranking_page.dart
: matomo upgradeproduct_list_page.dart
: matomo upgradeproduct_query_page.dart
: matomo upgradepubspec.lock
: wtfpubspec.yaml
: upgraded flutter_map to 6.0.1 (+ domino effect)question_page.dart
: matomo upgradesign_up_page.dart
: matomo upgradeuser_preferences_page.dart
: matomo upgrade