Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 4725 - refresh of the ios folder for background tasks #4772

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: 4725 - refresh of the ios folder for background tasks #4772

merged 1 commit into from
Nov 13, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • On ios, the standard app folders change regularly. The files are still there, but the folder is different.
  • This PR fixes a top sentry issue, where in background tasks we cannot find temporary files because the folder name changed.

Fixes bug(s)

Impacted files

  • background_task_crop.dart: now using new safe method getFile instead of just File
  • background_task_image.dart: now using new safe method getFile instead of just File
  • background_task_upload.dart: now fixing the ios directory
  • crop_page.dart: now using a shared directory

@monsieurtanuki
fix: 4725 - refresh of the ios folder for background tasks
2329a09 
Impacted files:
* `background_task_crop.dart`: now using new safe method `getFile` instead of just `File`
* `background_task_image.dart`: now using new safe method `getFile` instead of just `File`
* `background_task_upload.dart`: now fixing the ios directory
* `crop_page.dart`: now using a shared directory
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner November 8, 2023 11:53
@codecov-commenter
Copy link

Codecov Report

Merging #4772 (2329a09) into develop (21469af) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4772      +/-   ##
==========================================
- Coverage     9.89%   9.89%   -0.01%     
==========================================
  Files          312     312              
  Lines        15809   15818       +9     
==========================================
  Hits          1565    1565              
- Misses       14244   14253       +9
Files Coverage Δ
packages/smooth_app/lib/pages/crop_page.dart 0.00% <0.00%> (ø)
...mooth_app/lib/background/background_task_crop.dart 0.00% <0.00%> (ø)
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...oth_app/lib/background/background_task_upload.dart 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@teolemon teolemon added 🍎 iOS iOS specific issues or PRs background tasks labels Nov 8, 2023
@teolemon
Copy link
Member

teolemon commented Nov 9, 2023

FYI, @g123k is off this week.

g123k
g123k approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this behavior, but LGTM 👍

@monsieurtanuki monsieurtanuki merged commit ba9c347 into openfoodfacts:develop Nov 13, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k g123k approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
background tasks 🍎 iOS iOS specific issues or PRs
Projects
None yet
Milestone
No milestone
4 participants
@monsieurtanuki @codecov-commenter @teolemon @g123k