-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for '-' in nutritional values #4909
feat: Support for '-' in nutritional values #4909
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4909 +/- ##
==========================================
- Coverage 9.67% 9.66% -0.02%
==========================================
Files 318 318
Lines 16115 16145 +30
==========================================
+ Hits 1559 1560 +1
- Misses 14556 14585 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
My 2 cents:
- I confirm that I find the UI ugly and not very intuitive
- I'm not sure it will fit on small screens with your extra column
- I'm a bit surprised that you manage to put
-
as adouble?
value - I would have expected you to editNutritionContainer
too. But I probably haven't had a look at all the details of your code
As long as it works, I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is a bit too big. Please consider splitting it.
Hi everyone!
Here is an implementation for #4745: the fact that a value is not available on the product.
In addition to this modification, there is also:
TextEditingControllerWithInitialValue
renamed toTextEditingControllerWithHistory
, to also store the previous valueMediaQuery
are replaced by the flex mechanismProvider
_NutritionCellTextWatcher
is used to only call when a value is set or notA video of the implementation:
3.mov