Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added neutral action to Smooth Alert dialog and updated app review dialog in login page #5086

Merged

Conversation

Smit56R
Copy link
Contributor

@Smit56R Smit56R commented Feb 25, 2024

What

  • Added neutralAction to SmoothAlertDialog.
  • Updated the _showInAppReviewIfNecessary() function in login_page.dart to include the 'Ask me later' button.

Screenshot

Screenshot 1

Part of

@Smit56R Smit56R requested a review from a team as a code owner February 25, 2024 14:44
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label Feb 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 9.54%. Comparing base (4d9c7fc) to head (234c716).
Report is 36 commits behind head on develop.

Files Patch % Lines
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 57.14% 9 Missing ⚠️
...ooth_app/lib/pages/user_management/login_page.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5086      +/-   ##
==========================================
- Coverage     9.54%   9.54%   -0.01%     
==========================================
  Files          325     327       +2     
  Lines        16411   16517     +106     
==========================================
+ Hits          1567    1576       +9     
- Misses       14844   14941      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Smit56R for your first PR!

There is a slight misunderstanding that you'll have no problem fixing:

  • the point of adding a neutral button is only to have another horizontal or vertical button - please forget the "one button on top and two buttons on the bottom" option and just implement 3 buttons in a row or 3 buttons in a column
  • the point of "merging" the versions was mainly to reuse the same labels - the goal is to have the same 3 options with the same 3 labels when we ask our "do you like this app?" question.

As in the following screenshot:
Screenshot 1

Therefore please make sure that in the login page we use vertically the following labels:

  • tagline_app_review_button_positive
  • tagline_app_review_button_negative
  • tagline_app_review_button_later

@Smit56R
Copy link
Contributor Author

Smit56R commented Feb 25, 2024

@monsieurtanuki Got it. I will make the changes and update the PR.

@Smit56R
Copy link
Contributor Author

Smit56R commented Feb 25, 2024

@monsieurtanuki I have updated the PR with the changes requested.

Co-authored-by: monsieurtanuki <fabrice_fontaine@hotmail.com>
@monsieurtanuki monsieurtanuki linked an issue Feb 25, 2024 that may be closed by this pull request
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Smit56R! Congratulations!

@Smit56R
Copy link
Contributor Author

Smit56R commented Feb 25, 2024

Thank you @monsieurtanuki! You have been so polite.

@monsieurtanuki
Copy link
Contributor

@Smit56R For the record I don't understand the 2 screenshots, vertical and horizontal.
Maybe I've missed something but the goal of this PR is only the vertical version, and we need to be sure that the login page will display the buttons vertically.
I guess the idea was just to say "by the way the PR also includes a possibility of displaying 3 buttons horizontally, mainly for code coherence reasons, but not to be used in that particular "love this app?" case and probably never, as 3 horizontal buttons would be a bit packed".
Thanks for the PR anyway ;)

@monsieurtanuki monsieurtanuki merged commit d704b58 into openfoodfacts:develop Feb 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge the 2 distinct "Like this app?" widgets into only one
3 participants