-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added neutral action to Smooth Alert dialog and updated app review dialog in login page #5086
feat: Added neutral action to Smooth Alert dialog and updated app review dialog in login page #5086
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5086 +/- ##
==========================================
- Coverage 9.54% 9.54% -0.01%
==========================================
Files 325 327 +2
Lines 16411 16517 +106
==========================================
+ Hits 1567 1576 +9
- Misses 14844 14941 +97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Smit56R for your first PR!
There is a slight misunderstanding that you'll have no problem fixing:
- the point of adding a neutral button is only to have another horizontal or vertical button - please forget the "one button on top and two buttons on the bottom" option and just implement 3 buttons in a row or 3 buttons in a column
- the point of "merging" the versions was mainly to reuse the same labels - the goal is to have the same 3 options with the same 3 labels when we ask our "do you like this app?" question.
As in the following screenshot:
Therefore please make sure that in the login page we use vertically the following labels:
- tagline_app_review_button_positive
- tagline_app_review_button_negative
- tagline_app_review_button_later
@monsieurtanuki Got it. I will make the changes and update the PR. |
@monsieurtanuki I have updated the PR with the changes requested. |
packages/smooth_app/lib/generic_lib/dialogs/smooth_alert_dialog.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: monsieurtanuki <fabrice_fontaine@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @Smit56R! Congratulations!
Thank you @monsieurtanuki! You have been so polite. |
@Smit56R For the record I don't understand the 2 screenshots, vertical and horizontal. |
What
neutralAction
toSmoothAlertDialog
._showInAppReviewIfNecessary()
function inlogin_page.dart
to include the 'Ask me later' button.Screenshot
Part of