-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5 new icons: chicken / fish / milk / soda happy / soda unhappy #5268
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5268 +/- ##
==========================================
- Coverage 9.54% 8.58% -0.97%
==========================================
Files 325 330 +5
Lines 16411 16829 +418
==========================================
- Hits 1567 1444 -123
- Misses 14844 15385 +541 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Why do we need a happy soda btw ?
It's not used for the the Nutriscore guide, but it can be later. |
LGTM |
Oops, I forgot the salt icon |
Approved @g123k |
Thanks, I need this PR for the guide. |
Hi everyone,
Here are 5 new icons required by the Nutri-Score V2 guide:
