Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Guide for Nutri-Score V2 #5273

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 19, 2024

Hi everyone!

Here is the first PR to include the guide to explain the Nutri-Score V2.
This first PR only injects the content: the screen is not accessible by any means.

A few things to know:

  • All translations are fetched directly from Crowdin (intl is limited to 1 file as of now)
  • This screen is temporary and will be replaced later by a call to a Wordpress

Screenshot:
Screenshot 2024-05-19 at 19 25 00

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 8.49%. Comparing base (4d9c7fc) to head (251a5e3).
Report is 125 commits behind head on develop.

Files Patch % Lines
...ackages/smooth_app/lib/helpers/strings_helper.dart 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5273      +/-   ##
==========================================
- Coverage     9.54%   8.49%   -1.06%     
==========================================
  Files          325     335      +10     
  Lines        16411   17002     +591     
==========================================
- Hits          1567    1444     -123     
- Misses       14844   15558     +714     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved We'll have to get second opinions on the content itself

@teolemon teolemon merged commit dbd23f5 into openfoodfacts:develop May 21, 2024
6 checks passed
@g123k g123k deleted the nutriscore_guide branch May 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants