-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support for photos in a different language than the default one (green buttons) #5278
fix: Support for photos in a different language than the default one (green buttons) #5278
Conversation
…en field is available
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5278 +/- ##
==========================================
- Coverage 9.54% 8.19% -1.36%
==========================================
Files 325 356 +31
Lines 16411 17920 +1509
==========================================
- Hits 1567 1468 -99
- Misses 14844 16452 +1608 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
Your fix is surely an improvement, as it checks not only the current language, but all languages.
I'm afraid it's not 100% good, as the previous version (and yours) only check "transient files" (which are pictures that have not been received by the server yet).
If an image is received by the server, the local product is refreshed (with the new image) and the transient file is removed.
I would suggest using getProductImageLanguages
instead.
Thanks for your suggestion, I've checked in the 2 cases and it should be OK now |
Oops, there is a merge just after my commit. |
Hi everyone,
In the "Fast-track" screen, if the photo is uploaded in a different language than the default one, the button stays gray.
The fix here is to check if at least one photo is pending for the given field.