Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snap scrolling for guides #5283

Merged
merged 8 commits into from
May 25, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 24, 2024

Better than words, a video:
https://github.com/openfoodfacts/smooth-app/assets/246838/ff3c3a31-8d8f-4b62-acaa-2980382932f6

Or in plain text, if we scroll within the header, it will automatically scroll at the beginning/end (depending on the position).

This PR also includes all custom ScrollPhysics from the new design.

@g123k g123k self-assigned this May 24, 2024
@g123k g123k requested a review from a team as a code owner May 24, 2024 06:37
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0.59880% with 166 lines in your changes are missing coverage. Please review.

Project coverage is 8.10%. Comparing base (4d9c7fc) to head (d0b712a).
Report is 132 commits behind head on develop.

Files Patch % Lines
packages/smooth_app/lib/helpers/physics.dart 0.00% 137 Missing ⚠️
...h_app/lib/pages/guides/helpers/guides_content.dart 3.33% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5283      +/-   ##
==========================================
- Coverage     9.54%   8.10%   -1.45%     
==========================================
  Files          325     357      +32     
  Lines        16411   18113    +1702     
==========================================
- Hits          1567    1468      -99     
- Misses       14844   16645    +1801     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k
Copy link
Collaborator Author

g123k commented May 24, 2024

@teolemon teolemon merged commit 8338e90 into openfoodfacts:develop May 25, 2024
6 checks passed
@g123k g123k deleted the nutriscore_guide2 branch May 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants