Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better error message for search screen #5298

Merged
merged 2 commits into from
May 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 27, 2024

Hi everyone,

We're having server problems at the moment.
I'd like to take this opportunity to explain the errors in a little more detail and potentially allow users to send them to us:

After:
Screenshot 2024-05-27 at 20 00 43

Before (in French sorry):
Screenshot 2024-05-27 at 19 55 10

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 7.94%. Comparing base (4d9c7fc) to head (4e6b90f).
Report is 144 commits behind head on develop.

Files Patch % Lines
...ib/pages/product/common/product_dialog_helper.dart 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5298      +/-   ##
==========================================
- Coverage     9.54%   7.94%   -1.60%     
==========================================
  Files          325     368      +43     
  Lines        16411   18531    +2120     
==========================================
- Hits          1567    1473      -94     
- Misses       14844   17058    +2214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

A copy paste icon perhaps?

@g123k
Copy link
Collaborator Author

g123k commented May 28, 2024

My initial idea was to add a "Send an email" button, but I think we will be spammed.
I'm not really convinced by the copy/paste button, it's too geeky

@teolemon teolemon merged commit 4b6ed1e into openfoodfacts:develop May 28, 2024
6 checks passed
@g123k g123k deleted the product_error branch December 30, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants