Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: currency symbols #5311

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added currency symbols, in display and in filter, so that users can find and see more easily the currencies.
  • En passant fixed a bug on filtering that didn't work with uppercase inputs for country and currency.

Screenshots

filter with diacritics filter on $ filter on both name and symbol
Screenshot_1717078611 Screenshot_1717078596 Screenshot_1717079002

Files

New file:

  • currency_extension.dart: Currency symbols.

Impacted files:

  • country_selector.dart: fixed a typo that prevented the filter from working with uppercase.
  • currency_selector.dart: displayed the new currency full name
  • currency_selector_helper.dart: displayed the new currency full name; fixed a typo that prevented the filter from working with uppercase.
  • price_currency_selector.dart: displayed the new currency full name
  • smooth_text.dart: managed the case where we search for special chars like $

New file:
* `currency_extension.dart`: Currency symbols.

Impacted files:
* `country_selector.dart`: fixed a typo that prevented the filter from working with uppercase.
* `currency_selector.dart`: displayed the new currency full name
* `currency_selector_helper.dart`: displayed the new currency full name; fixed a typo that prevented the filter from working with uppercase.
* `price_currency_selector.dart`: displayed the new currency full name
* `smooth_text.dart`: managed the case where we search for special chars like $
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 30, 2024 14:26
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Prices labels May 30, 2024
@monsieurtanuki monsieurtanuki requested a review from teolemon May 30, 2024 14:27
@monsieurtanuki monsieurtanuki merged commit 4db1d6c into openfoodfacts:develop May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Prices
Development

Successfully merging this pull request may close these issues.

2 participants