Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5352 - now opening the related product price page from count button #5353

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now the "price count" button opens the related product price page.
  • Unless you're already on the single product price page.

Screenshots

latest prices page product price page
Screenshot_1718027622 Screenshot_1718027629

Fixes bug(s)

Impacted files

  • edit_product_page.dart: minor refactoring
  • get_prices_model.dart: refactored with 2 new constructors
  • price_count_widget.dart: now opening the related product price page (if relevant)
  • price_product_widget.dart: minor refactoring
  • prices_card.dart: minor refactoring
  • product_price_add_page.dart: minor refactoring
  • product_prices_list.dart: minor refactoring; minor bug fix
  • user_preferences_account.dart: minor refactoring

…tton

Impacted files:
* `edit_product_page.dart`: minor refactoring
* `get_prices_model.dart`: refactored with 2 new constructors
* `price_count_widget.dart`: now opening the related product price page (if relevant)
* `price_product_widget.dart`: minor refactoring
* `prices_card.dart`: minor refactoring
* `product_price_add_page.dart`: minor refactoring
* `product_prices_list.dart`: minor refactoring; minor bug fix
* `user_preferences_account.dart`: minor refactoring
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 7.40%. Comparing base (4d9c7fc) to head (151a8bb).
Report is 175 commits behind head on develop.

Files Patch % Lines
.../smooth_app/lib/pages/prices/get_prices_model.dart 0.00% 23 Missing ⚠️
...mooth_app/lib/pages/prices/price_count_widget.dart 0.00% 17 Missing ⚠️
...h_app/lib/pages/prices/product_price_add_page.dart 0.00% 11 Missing ⚠️
...ooth_app/lib/pages/prices/product_prices_list.dart 0.00% 7 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 4 Missing ⚠️
...oth_app/lib/pages/prices/price_product_widget.dart 0.00% 4 Missing ⚠️
...kages/smooth_app/lib/pages/prices/prices_card.dart 0.00% 3 Missing ⚠️
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5353      +/-   ##
==========================================
- Coverage     9.54%   7.40%   -2.14%     
==========================================
  Files          325     380      +55     
  Lines        16411   19423    +3012     
==========================================
- Hits          1567    1439     -128     
- Misses       14844   17984    +3140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki :-)

@teolemon teolemon merged commit 536eae4 into openfoodfacts:develop Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Jumping from the "Last added prices" and "My Prices" to the individual price page for the product
3 participants