Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5560 - proof files from PROD/DEV #5561

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • When displaying the proof image files, we used the product PROD/DEV settings instead of the prices PROD/DEV settings
  • That's now fixed here. Didn't test it, though, in order to push a quick fix.

Fixes bug(s)

Impacted files

  • price_proof_page.dart: used prices PROD/DEV instead of product PROD/DEV settings
  • prices_proofs_page.dart: used prices PROD/DEV instead of product PROD/DEV settings

Impacted files:
* `price_proof_page.dart`: used prices PROD/DEV instead of product PROD/DEV settings
* `prices_proofs_page.dart`: used prices PROD/DEV instead of product PROD/DEV settings
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.96%. Comparing base (4d9c7fc) to head (bf02db2).
Report is 292 commits behind head on develop.

Files Patch % Lines
.../smooth_app/lib/pages/prices/price_proof_page.dart 0.00% 1 Missing ⚠️
...mooth_app/lib/pages/prices/prices_proofs_page.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5561      +/-   ##
==========================================
- Coverage     9.54%   6.96%   -2.59%     
==========================================
  Files          325     400      +75     
  Lines        16411   21172    +4761     
==========================================
- Hits          1567    1474      -93     
- Misses       14844   19698    +4854     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202
Copy link

Thank you!
I will test this on internal

@raphael0202 raphael0202 merged commit c50a10c into openfoodfacts:develop Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

When using "DEV" server for Open Prices, images are still fetched from PROD server
3 participants