Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misc visual improvements #5829

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 10, 2024

Hi everyone!

Here are a few visual improvements:

AppBar

  • The AppBar now has a shadow by default (removed by Material 3 😵‍💫)
  • The AppBar font size is a bit smaller (regression after Material 3)
    Screenshot_1731213398

Edit page:

  • The Nutrition Facts icon is taken from the font and not the SVG (no visual change)

  • The Edit icon is taken from the front (a bit rounded)

  • The Country icon is taken from the front (a bit rounded)

  • "Add a price" uses the same icon as in the Product page
    Screenshot_1731213404

  • fix: Some SVGs were opting for the wrong color in dark mode
    Screenshot_1731213482

Misc

  • CurrencySelectorHelper has a singleton

@github-actions github-actions bot added 🥫 Product page 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users Prices labels Nov 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 7.07%. Comparing base (4d9c7fc) to head (47cedd2).
Report is 452 commits behind head on develop.

Files with missing lines Patch % Lines
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% 15 Missing ⚠️
...lib/pages/onboarding/currency_selector_helper.dart 0.00% 3 Missing ⚠️
...ackages/smooth_app/lib/widgets/smooth_app_bar.dart 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5829      +/-   ##
==========================================
- Coverage     9.54%   7.07%   -2.48%     
==========================================
  Files          325     413      +88     
  Lines        16411   22540    +6129     
==========================================
+ Hits          1567    1595      +28     
- Misses       14844   20945    +6101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k mentioned this pull request Nov 10, 2024
4 tasks
@teolemon teolemon merged commit 054ac0d into openfoodfacts:develop Nov 11, 2024
6 checks passed
@teolemon
Copy link
Member

thanks a lot @g123k 🌊

@g123k g123k deleted the misc_improvements branch November 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Prices 🥫 Product page
Development

Successfully merging this pull request may close these issues.

3 participants