-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1392 - added "select all" and "select none" actions for product lists #5842
Conversation
… lists Impacted files: * `app_en.arb`: added 3 labels (2 new actions, 1 previously not localized) * `product_list_item_popup_items.dart`: added 2 actions; minor refactoring * `product_list_page.dart`: added 2 actions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5842 +/- ##
==========================================
- Coverage 9.54% 6.92% -2.63%
==========================================
Files 325 422 +97
Lines 16411 23245 +6834
==========================================
+ Hits 1567 1609 +42
- Misses 14844 21636 +6792 ☔ View full report in Codecov by Sentry. |
@monsieurtanuki Can you add "$s selected products", instead of just the number of selected products? |
Initially I tried that one but it looked weird - like you're selecting a check box. |
Impacted files: * `app_en.arb`: added 1 label for multiselect title * `product_list_item_popup_items.dart`: changed the icon for none * `product_list_page.dart`: more refined multiselect title
@teolemon Done.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's a plus to the current situation, thanks @monsieurtanuki 👍
Thank you @teolemon for your review! |
What
Screenshots
Part of
Impacted files:
app_en.arb
: added 3 labels (2 new actions, 1 previously not localized)product_list_item_popup_items.dart
: added 2 actions; minor refactoringproduct_list_page.dart
: added 2 actions