Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1392 - added "select all" and "select none" actions for product lists #5842

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added the "select all" and "select none" options for product list in multi-select mode.

Screenshots

none selected all selected
Screenshot_1731347393 Screenshot_1731347426

Part of

Impacted files:

  • app_en.arb: added 3 labels (2 new actions, 1 previously not localized)
  • product_list_item_popup_items.dart: added 2 actions; minor refactoring
  • product_list_page.dart: added 2 actions

… lists

Impacted files:
* `app_en.arb`: added 3 labels (2 new actions, 1 previously not localized)
* `product_list_item_popup_items.dart`: added 2 actions; minor refactoring
* `product_list_page.dart`: added 2 actions
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 6.92%. Comparing base (4d9c7fc) to head (9584f1d).
Report is 468 commits behind head on develop.

Files with missing lines Patch % Lines
.../product/common/product_list_item_popup_items.dart 0.00% 11 Missing ⚠️
...pp/lib/pages/product/common/product_list_page.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5842      +/-   ##
==========================================
- Coverage     9.54%   6.92%   -2.63%     
==========================================
  Files          325     422      +97     
  Lines        16411   23245    +6834     
==========================================
+ Hits          1567    1609      +42     
- Misses       14844   21636    +6792     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

@monsieurtanuki Can you add "$s selected products", instead of just the number of selected products?

@teolemon
Copy link
Member

Screenshot_20241111-191147.png

We have an unselected icon available in material symbols

@monsieurtanuki
Copy link
Contributor Author

We have an unselected icon available in material symbols

Initially I tried that one but it looked weird - like you're selecting a check box.
Can put it back, sure.

Impacted files:
* `app_en.arb`: added 1 label for multiselect title
* `product_list_item_popup_items.dart`: changed the icon for none
* `product_list_page.dart`: more refined multiselect title
@monsieurtanuki
Copy link
Contributor Author

@teolemon Done.

None selected All selected One selected
Screenshot_1731349445 Screenshot_1731349456 Screenshot_1731349469

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's a plus to the current situation, thanks @monsieurtanuki 👍

@teolemon teolemon merged commit 2784043 into openfoodfacts:develop Nov 11, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants