-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI Improvements for the photo gallery #5852
Conversation
4a5d4e3
to
d79a779
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5852 +/- ##
==========================================
- Coverage 9.54% 6.90% -2.65%
==========================================
Files 325 423 +98
Lines 16411 23352 +6941
==========================================
+ Hits 1567 1612 +45
- Misses 14844 21740 +6896 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
Nothing special to report.
onTap: () async => Navigator.push<void>( | ||
context, | ||
MaterialPageRoute<bool>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void or bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, that's a copy/paste from the current code.
I'll fix that
Hi everyone!
Here are a few changes to the photo gallery.
🎥 https://github.com/user-attachments/assets/91d52794-a613-4ee7-97ed-f0a8ff30a38e
The "Take a picture" button (was in the FAB) is moved into the
AppBar
The language picker is also in the
AppBar
The grid layout is changed
The indicator on the left is green (up-to-date photo), orange (maybe outdated), red (no picture available)
The type is on top and not below
The text is not shrunk
The image is not centered anymore and uses the same effect as the product page.

File changes:
product_title_card.dart
: everything related to the product picture is removed from this filesmooth_product_image.dart
: the code fromproduct_title_card.dart
+ new featuresproduct_cards_helper.dart
: the "ProductAppBar" can have actions and a bottom widgetproduct_image_widget.dart
: in the grid, the obsolete icon is now orangeproduct_image_gallery_view.dart
: use the new layoutproduct_image_viewer.dart
: add a Hero animationapp_icons.dart
: two variants for theCircledArrow
smooth_theme.dart
: instead ofTheme.of().extension<>…!
, we can usecontext.extension<>()
smooth_app_bar.dart
: the foreground color was not passed correctly to the title