-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5952 - better image compression for Prices #6048
feat: 5952 - better image compression for Prices #6048
Conversation
Impacted files: * `image_compute_container.dart`: added the compression quality parameter * `background_task_image.dart`: added the compression quality and force quality parameters; same parameters as before for OxF images (quality 100, no forced compression for non cropped images) * `background_task_add_price.dart`: always compress the proof image, with quality 80
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6048 +/- ##
==========================================
- Coverage 9.54% 6.46% -3.09%
==========================================
Files 325 443 +118
Lines 16411 25140 +8729
==========================================
+ Hits 1567 1625 +58
- Misses 14844 23515 +8671 ☔ View full report in Codecov by Sentry. |
sorry, what ? |
@raphodn It looks like you assumed I meant "complain" in a negative way, like "whine" or "groan" (e.g. "French people always complain"). The title of the PR is about "better image compression", and in the description I also question our current settings for OFF images that would probably be improved in the same way. Just a couple of "constructive" use of "complain" from https://www.merriam-webster.com/sentences/complain, and both about IT:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
What
.webp
files being only partially supported in flutter, the solution was to keep.jpeg
as a format, but with different compression parameters..webp
), and all images will be compressed (including images that are not cropped and that were sent as-is)Fixes bug(s)
Impacted files
image_compute_container.dart
: added the compression quality parameterbackground_task_image.dart
: added the compression quality and force quality parameters; same parameters as before for OxF images (quality 100, no forced compression for non cropped images)background_task_add_price.dart
: always compress the proof image, with quality 80