Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migration to the latest camera/mobile_scanner #6075

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 27, 2024

Hi everyone!

I won't have enough time to embed the new homepage in the app.
Here is, at least, a bump to the latest versions of camera/mobile_scanner.

Now, the scanner will start/stop correctly.
I also have to bump the min version (iOS 15 and Android 6)

@github-actions github-actions bot added 🍎 iOS iOS specific issues or PRs Android dependencies labels Dec 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.44%. Comparing base (4d9c7fc) to head (2594b91).
Report is 581 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6075      +/-   ##
==========================================
- Coverage     9.54%   6.44%   -3.11%     
==========================================
  Files          325     444     +119     
  Lines        16411   25206    +8795     
==========================================
+ Hits          1567    1625      +58     
- Misses       14844   23581    +8737     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

How much testing do we need on this one @g123k ?

@g123k
Copy link
Collaborator Author

g123k commented Dec 27, 2024

How much testing do we need on this one @g123k ?

If you can, retest everything (closing the app, reopening from an opened product...).
This is OK for iOS, but may need some extra testing on Android

@teolemon teolemon merged commit a89f7a5 into openfoodfacts:develop Dec 28, 2024
6 checks passed
@g123k g123k deleted the m2 branch December 30, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android dependencies 🍎 iOS iOS specific issues or PRs
Development

Successfully merging this pull request may close these issues.

3 participants