Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nutriscore/greenscore logo: wrong size / padding #6131

Closed
monsieurtanuki opened this issue Jan 6, 2025 · 1 comment · Fixed by #6161
Closed

New nutriscore/greenscore logo: wrong size / padding #6131

monsieurtanuki opened this issue Jan 6, 2025 · 1 comment · Fixed by #6161
Assignees

Comments

@monsieurtanuki
Copy link
Contributor

What

  • The new nutriscore logo doesn't look correctly aligned / padded compared to the previous nutriscore logo
  • That happens especially when it's displayed with the old nutriscore or the ecoscore

Steps to reproduce the behavior

  1. Go to a product list
  2. Products with new nutriscore logo don't look correct

Expected behavior

We should see aligned logos, possibly with a padding (wasn't necessary with the previous logo as it had extra bottom pixels around the score)

Screenshot/Mockup/Before-After

Image

@monsieurtanuki monsieurtanuki changed the title New nutriscore logo: wrong size / padding New nutriscore/greenscore logo: wrong size / padding Jan 6, 2025
@g123k
Copy link
Collaborator

g123k commented Jan 8, 2025

I will implement the design from the POC and fix this at the same time.
As a reminder:

Image

@g123k g123k self-assigned this Jan 8, 2025
@g123k g123k linked a pull request Jan 9, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants