Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Folksonomy Editor (updated UI, modal sheet…) #6194

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 13, 2025

Hi everyone!

This PR changes a lot of things for the taxonomy editor.
Better than words, a video:

ScreenRecording_01-13-2025.12-56-12_1.MP4

@g123k g123k changed the title feat: Taxonomy Editor (updated UI, modal sheet…) feat: Folksonomy Editor (updated UI, modal sheet…) Jan 13, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0.83565% with 356 lines in your changes missing coverage. Please review.

Project coverage is 6.23%. Comparing base (4d9c7fc) to head (402adab).
Report is 650 commits behind head on develop.

Files with missing lines Patch % Lines
...ooth_app/lib/pages/folksonomy/folksonomy_page.dart 0.00% 109 Missing ⚠️
...pages/folksonomy/folksonomy_create_edit_modal.dart 0.00% 107 Missing ⚠️
..._app/lib/pages/folksonomy/folksonomy_provider.dart 2.98% 65 Missing ⚠️
...ooth_app/lib/pages/folksonomy/folksonomy_card.dart 1.56% 63 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 7 Missing ⚠️
...ages/smooth_app/lib/widgets/v2/smooth_topbar2.dart 0.00% 3 Missing ⚠️
...ges/smooth_app/lib/widgets/smooth_menu_button.dart 0.00% 1 Missing ⚠️
.../smooth_app/lib/widgets/v2/smooth_buttons_bar.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6194      +/-   ##
==========================================
- Coverage     9.54%   6.23%   -3.32%     
==========================================
  Files          325     456     +131     
  Lines        16411   26516   +10105     
==========================================
+ Hits          1567    1654      +87     
- Misses       14844   24862   +10018     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 995cb1b into openfoodfacts:develop Jan 13, 2025
7 checks passed
@g123k g123k deleted the taxonomy branch January 13, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

White on white for the Folksonomy Engine Give more room to tag input for the Folksonomy Engine
3 participants