-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve KP tables layout #6080
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6080 +/- ##
==========================================
- Coverage 9.54% 6.42% -3.13%
==========================================
Files 325 445 +120
Lines 16411 25297 +8886
==========================================
+ Hits 1567 1625 +58
- Misses 14844 23672 +8828 ☔ View full report in Codecov by Sentry. |
@g123k do you have a screenshot of the nutrition table (eg for "milumel") ? |
Why not centering deviation to category values as well ? And the 100g title ? @g123k |
The problem is that sometimes it's OK to center and sometimes not. It would be better if the API could provide a % for each column (and not let us guess it) and the same goes for the alignment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved @g123k
Hi everyone!
KP tables often seem not well-balanced.
This PR tries to improve them: