-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Setup basic FastAPI project #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aadarsh-ram just a comment to already structure the project.
@alexgarel Please review this PR, and let me know your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aadarsh-ram, good work.
I'm not ok with your shema.json and test.json, but let's merge first, for this is another problem.
For me we have to work with the neo4j database, maybe I should provide you with the sample data to import in neo4j which correspond to test.txt
@@ -0,0 +1,37 @@ | |||
# test taxonomy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for having wrote this test. This will be usefull to @BryanH01 also, I guess.
@@ -0,0 +1,50 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't argue over the need of this schema.json, I really think we will do it all in the neo4j database. But let's get them in, for now we shall see later.
However there are mismatches with the spec.
For example:
- "preceding_lines" is a list of strings.
- no
__comments__
block is mentionned stopwords:IDX
andsynonyms:IDX
are distinct nodes from__header__
- etc.
But your schema has it's own logic per se… it's more than we must align :-)
Maybe we should better discuss the neo4j schema (in facts it's schema less) and have the equivalent of test.txt as an importable file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sure! We'll discuss the structure of JSON, and bring a unified schema.
Fixes #6
What
Part of