Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new user with USER_GID parameter & replace root user #113

Merged
merged 6 commits into from
Oct 19, 2022
Merged

feat: add new user with USER_GID parameter & replace root user #113

merged 6 commits into from
Oct 19, 2022

Conversation

Aju100
Copy link
Contributor

@Aju100 Aju100 commented Oct 12, 2022

Fixed #63

@Aju100 Aju100 requested a review from a team as a code owner October 12, 2022 12:24
@Aju100
Copy link
Contributor Author

Aju100 commented Oct 14, 2022

@alexgarel Can you please review out this PR

alexgarel
alexgarel reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aju100 so far so good, but you also have to change docker-compose and split the build part (with args) in a docker/dev.yml as you did for facets-knowledge-panels.

backend/Dockerfile Outdated Show resolved Hide resolved
@Aju100 Aju100 requested a review from alexgarel October 15, 2022 02:30
@alexgarel
Copy link
Member

@Aju100, a tip: when you fork a project, don't work on branch main, but create a new branch for you feature, then create a PR against source project.

If you work on main branch, you won't be able to resync your fork with upstream project.

alexgarel
alexgarel approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Aju100 !

Thank you so much.

@alexgarel alexgarel merged commit 6fb1b4c into openfoodfacts:main Oct 19, 2022
@aadarsh-ram
Copy link
Collaborator

Thanks for the contribution @Aju100! 🎉

@Aju100
Copy link
Contributor Author

Aju100 commented Oct 20, 2022

Thank you @alexgarel for the feedback, will definitely check out it in an upcoming collaboration. Also thank you @aadarsh-ram appreciated it.

@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@Aju100 Aju100

Labels
None yet
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not run api service as root
3 participants
@Aju100 @alexgarel @aadarsh-ram